curl-library
Re: PATCH: Do not allow multi interface to block trying to perform DNS on interface names
Date: Tue, 8 Nov 2011 11:11:58 -0500
On Sat, Nov 5, 2011 at 11:11 PM, Jason Glasgow <jglasgow_at_google.com> wrote:
> On Fri, Nov 4, 2011 at 6:45 PM, Daniel Stenberg <daniel_at_haxx.se> wrote:
>>
>> On Fri, 4 Nov 2011, Jason Glasgow wrote:
>>
>>> I think it would be clearer to just have two different options.
>>
>> Clearer? Yes. Breaking old programs? Yes. Acceptable? No.
>
> Okay. How about the patch below?
>>>
>>> - CURLOPT_INTERFACE which would only refer to an interface name
>>
>> Right, but it has been documented to accept a host name as well for about
>> 200 years. Changing this now will break programs. We can't do this.
>>
>> We would have to add two new options.
>>
>>> I do admit that this would require rework of some clients -- but I think
>>> this is reasonable because the two are distinct arguments, and clients may
>>> have to be rewritten anyway if they want to add the if! or host! prefix.
>>
>> Adding prefixes will fix programs using the future libcurl version but all
>> existing program will remain working the same, and I find that a much
>> stronger argument...
>
> I have added if! and host! prefix processing and below is a refined patch.
> Comments welcome.
>
It looks like the patch was stripped
(http://curl.haxx.se/mail/lib-2011-11/0066.html)
I'm resending it as an attachment.
-Jason
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
- text/x-patch attachment: do-not-resolve-interface-names.patch