curl-library
Re: [PATCH] TFTP client's bad behaviour when unexpected block is received and not optimal timeouts
Date: Tue, 4 Oct 2011 23:03:56 +0200 (CEST)
On Tue, 4 Oct 2011, Marcin Adamski wrote:
> In version 7.21.5 (sorry for not relating to the latest version for some
> reasons, but as far as I know it was not corrected recently)
It has been the same for a while, indeed.
> I've discovered that when during download TFTP client receives a block that
> it did not expect, it does not acknowledge it and increase number of tries,
> what later can cause termination of transfer because of "TFTP illegal
> operation".
Can you please submit the patch made with diff -u instead?
> Moreover I don't think timeout for ACK retransmission should be dependent on
> timeout for whole operation. The bigger timeout, the slower transmission on
> networks with significant packet losses (when using windowing on server
> side).
Indeed a valid point!
BTW, this change calls for a test case to verify that it does the right thing.
Have you looked into how we can make one?
-- / daniel.haxx.se ------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.htmlReceived on 2011-10-04