Morning Daniel,

> > I have modified smtp_mail() to support the optional SIZE parameter
> > that may be included in a MAIL FROM command.
> > the size via CURLOPT_INFILESIZE.
>
> Looks fine and simple enough. I'll push it.

Thank you.

I also noticed that you fixed a memory leak I had introduced. Sorry about
that.

I see there is also the potential for another leak when "from" is
successfully allocated but "size" fails. I have attached a small patch to
fix this issue as well.

> Have you looked into adding usage of this feature into a test or two?

Not yet ;-)

I'm gradually getting more familiar with libcurl development, having done a
bit of coding and documentation (as you know) so I guess I should have a go
at drawing up some test cases as well.

I'm hoping to rework my last (from the 26th of August) SMTP NTLM patch over
the weekend, so I can have a look at some test cases after that - if that's
okay.

Regards

Steve

Received on 2011-09-30