On Mon, Sep 19, 2011 at 2:26 PM, Daniel Stenberg <daniel_at_haxx.se> wrote:

> On Mon, 19 Sep 2011, Amr Shahin wrote:
>
> Correct, i will change this to be something like this
>> #ifdef HAVE_POLL_FINE
>> static int Curl_socket_ready_helper
>> #else
>> static int Curl_socket_ready_helper
>> #endif
>>
>> both functions will have the same signature,
>>
>
> That looks good to me!
>
>
> this way only one will be compiled along with each build, and each one can
>> be tested separately.
>>
>
> Right. I think that's a limitation we can live with.
>
>
> --
>
> / daniel.haxx.se
> ------------------------------**------------------------------**-------
> List admin: http://cool.haxx.se/list/**listinfo/curl-library<http://cool.haxx.se/list/listinfo/curl-library>
> Etiquette: http://curl.haxx.se/mail/**etiquette.html<http://curl.haxx.se/mail/etiquette.html>
>

ok so i'm done with the patch, but i need to make sure i didn't break
anything, is there a certain test that would give me this certainty or do i
need to be creative?

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2011-09-26