Hi Daniel,

> I want to provide a follow up patch that will:
>
> * Move HOSTNAME_MAX into Curl_gethostname.h as there are
> definitions for this in Curl_gethostname.c and Curl_ntlm_msg.c
> * Modify smtp.c to use HOSTNAME_MAX rather than hardcoding
> it to 1024 (which happens to be the same length as
> HOSTNAME_MAX)
> * Tidy up Curl_ntlm_msg.c to remove the post Curl_gethostname()
> code that strips of the domain as this is no longer required

I have attached my tidy up changes as three separate patches to assist
traceability and GIT rollback.

* The first one adds support of HOSTNAME_MAX to smtp.c
* The second moves HOSTNAME_MAX into curl_gethostname.h
* The first tidies up the use of Curl_gethostname() into ntlm_msgs.c

I've also tried to comment the patch files / commit in the style that I've
noticed you and Yang use with a brief description followed by a more
informative description.

Kind Regards

Steve

Received on 2011-09-19