cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] allows curl to be able to send the custom headers with empty value.

From: warp kawada <warp.kawada_at_gmail.com>
Date: Mon, 5 Sep 2011 16:23:52 +0900

2011/9/3 Dan Fandrich <dan_at_coneharvesters.com>:
> There's no need to create a <tool> test for this, and the associated
> increased size, space and compile time hits. A test based on test4
> should be perfectly adequate.

OK.
I will append -H "X-Custom-Header;" to test4.

> its header must be terminated with a semicolon, such as \-H "X-Custom-Header;" to send
> "X-Custom-Header:".

OK. Thanks.

> Why not use strchr(ptr, ' ') here?

You're right. I'll do that.

> This will eliminate the header when the semicolon doesn't terminate the line,
> such as if someone accidentally used a semicolon instead of a colon. This
> isn't necessarily bad, but that could be a case that may be useful to use for
> for further extensions in the future. I suggest only allowing terminating
> semicolons for now.

I think I understand what you said.
But I don't know what should I do specifically.
My additional codes expect its header does not have colon.
Please tell me your logic.

Regards,
Thank you.
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2011-09-05