cURL / Mailing Lists / curl-library / Single Mail

curl-library

NTLM descriptor leak

From: Dan Fandrich <dan_at_coneharvesters.com>
Date: Fri, 2 Sep 2011 13:15:14 -0700

The torture tests are showing a file descriptor leak in test 1310 due to the
recent NTLM restructuring. The problem is that the NTLM help app is started
when ntlm.state == NTLMSTATE_NONE (ntlm_wb_init is called at line 336 of
curl_ntlm_wb.c), but if NTLM negotiation is then aborted due to an
OOM problem, Curl_disconnect doesn't call Curl_http_ntlm_cleanup in
that state (only when ntlm.state != NTLMSTATE_NONE).

It looks to me like either an NTLMSTATE_INIT state is needed to allow cleanup
to proceed, or Curl_http_ntlm_cleanup should be called unconditionally on
disconnect.

>>> Dan
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2011-09-03