cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: [PATCH] Added AUTH NTLM for SMTP

From: Steve Holme <steve_holme_at_hotmail.com>
Date: Wed, 10 Aug 2011 21:43:26 +0100

On Wed, 10 Aug 2011, Yang Tse wrote:

> Hi there,

Hi again ;-)

> As such, can you discard my last patch with the curl_ntlm move in? I
> will patch this up after this patch is pushed ;-)

> Relative to that one... It would be nice to keep the handling of out of
> memory condition when calling Curl_base64_* in the same function
> where Curl_base64_* is called. Probably it would be better if
> Curl_ntlm_create_type1_message() and
> Curl_ntlm_create_type3_message() did not call
> Curl_base64_encode().

Sorry - you've lost me a little :(

So to clarify, are you saying that the calls to Curl_base64_encode () should
be moved back into Curl_output_ntlm () ?

Cheers

Steve

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2011-08-10