cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] Added AUTH NTLM for SMTP

From: Yang Tse <yangsita_at_gmail.com>
Date: Mon, 8 Aug 2011 21:32:14 +0200

2011/8/8 Steve Holme wrote:

> From an outsider's perspective, this seems quite long winded, is it always
> like this? The reason I ask is, I've got some more features I would like to
> add to the SMTP module as well as some fixes for bugs that I have noticed.

Nah, it happens only when patches get big and additional development
has taken place recently in the same portions of code already in the
repository, and I get involved in trying my best to not break existing
code if I'm the one going to push it.

You've been lucky, three out of three ;-)

Other features won't need this amount of patch traceability, or you'll
get someone else to review your patch ;-) But if they make substantial
changes to existing code this is what should be done if someone has
the time to do it.

Dan has just expressed the same in a more technical reasoning.

-- 
-=[Yang]=-
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2011-08-08