On Tue, 28 Jun 2011, Wu, Mandy wrote:
>
> I have worked out a complete patch to implement this.
> And I also modified previous design to only do single-sign-on for NTLM
> authentication when client does not provide a password (conn->passwd is
> empty).

Great!

I've not actually ran it, but I built it fine on Linux without complaints. I'm
looking forward to seeing some tests for this. Also, this new feature needs a
word or two in the documentation.

Two words about your changes to include/curl/curl.h:

1 - that's a public header for user applications so it cannot use #ifdef
     USE_NTLM_SSO. Error codes should be independent of build features anyway
     so you can just provide them unconditionally.

2 - speaking of said error codes, it seems CURLE_NTLM_AUTH_FAILED is very
     specific for exactly this authentication method without any real need.
     Couldn't just the existing CURLE_REMOTE_ACCESS_DENIED or similar be used?

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html