On Tue, 28 Jun 2011, Pete Zaitcev wrote:

> This may be a case when code needs little explanation. Basically all I want
> is to set the service name in http_negotiate.c, and the rest is just my
> attempts to come up with some way to do it. I am not at all sure this is the
> best way to accomlish it, therefore RFC.

Thanks!

I'm no Kerberos expert, but if this need exists then I think your approach is
quite fine.

Two minor comments:

  o I would appreciate the new option(s) documented as well.

  o http_negotiate_sspi.c has pretty much the exact same logic duplicated (for
    builds that use the Windows SSPI instead of the libcurl provided code) so
    I would argue we should move out the building of the full service name into
    a separate function that can be used from both negotiate files.

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html