cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] NTLM & Astaro & bug 75

From: Matteo Rocco <matteo_at_icona.it>
Date: Thu, 21 Apr 2011 09:09:58 +0200

Hi Daniel,

in my use-case I don't have flag NTLMFLAG_NEGOTIATE_NTLM2_KEY

so these 3 lines of code

     if (unicode) {
         domlen = domlen * 2;
         userlen = userlen * 2;
         hostlen = hostlen * 2;
     }

should be placed before

#if USE_NTLM2SESSION
     /* We don't support NTLM2 if we don't have USE_NTRESPONSES */
     if(ntlm->flags & NTLMFLAG_NEGOTIATE_NTLM2_KEY) {

..as in my patch

Matteo

I made few changes to http_ntlm.c file to support NTLM authentication on
Astaro proxy.
>
> Thanks a lot Matteo!
>
> However, the code didn't follow our indent style, it wasn't C90
> compliant and I didn't like the repeated for-loops.
>
> I suggest we do it with a little helper-function instead, which I
> think makes the code much easier to follow and deal with. Have a look
> at the attached patch, and please tell me if you think I broke the
> functionality as I have no way of verifying your use-case!
>

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2011-04-21