cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: No surprise github pull requests please

From: Ben Noordhuis <info_at_bnoordhuis.nl>
Date: Sun, 10 Apr 2011 00:32:48 +0200

On Sun, Apr 10, 2011 at 00:21, Daniel Stenberg <daniel_at_haxx.se> wrote:
> At github.com, anyone can provide a patch for curl and send a "pull request"
> to me personally and ask me to get that patch into the curl master source
> tree.
>
> While I appreciate pull requests with good features and fixes, just sending
> a pull request to me is not OK unless we've discussed the changes on a
> suitable mailing list first.
>
> The pull requests only reach me personally. I don't like that more than I
> dislike private emails discussing project matters. I may not like the
> feature, but others may. Discussing coding style or alternative
> implementation approaches is better done with mail involving the entire
> development community. (Or I may just be absent personally and unable to
> respond while there's a bunch of others present on this list...)

You should mention this in the project's description on GH. People
that send in pull requests probably don't subscribe to the mailing
list, that is sort of the idea behind it - low barrier to entry.
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2011-04-10