cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Broken C Code

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Fri, 18 Feb 2011 20:09:31 +0100 (CET)

On Fri, 18 Feb 2011, Andreas Zwinkau wrote:

> i am trying to compile Curl with cparser[0], but it breaks, because of
> some invalid C code. The problem is in typecheck-gcc.h:

That breaks because your compiler tries to appear as gcc but fails to work
like one. You should report that to the makers of your compiler.

> The gcc behavior deviates from the ANSI C Standard.

... which is why we make an effort to only do that with a new enough gcc.

Can you help us improve the version check so that we can stop cparser from
messing things up?

> A counter-argument would be that is ok that typecheck-gcc.h relies on
> implementation-specific gcc behavior, but non-portable code should be
> avoided.

That's pure BS. Things that improve the project are good - even if not
everyone might be able to take advantage of every improvement.

This particular set of macros help users with gcc a lot to avoid mistakes in
their applications. Why wouldn't we provide this help if we can and have the
ability?

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2011-02-18