cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: SFTP file info and state machine

From: John Utz <john_at_utzweb.net>
Date: Fri, 28 Jan 2011 22:55:23 -0500 (EST)

Hi Dan;

----- Original Message -----
> ----- Original Message -----
> > On Thu, 27 Jan 2011, John Utz wrote:
> >
> > >> Weren't you talking SFTP? Then you should only look in lib/ssh.c.
> > >> SFTP has
> > >> very little to do with FTP apart from sounding very similar...
> > >
> > > IIRC your original mail on the topic indicated that it would be
> > > easy
> > > to add
> > > it to ssh and i assumed that it would be copy and paste from what
> > > was in
> > > ftp, if i cant start from what's in ftp then how is it an easy
> > > fix?
> > > what
> > > code will i evolve to make this work?
> >
> > Right, I meant that as a source for inspiration on how to start. But
> > then
> > there was this initial patch to which I replied my comments:
> > http://curl.haxx.se/mail/lib-2011-01/0244.html
> >
> > That is almost there, you just need to fix the minor flaws and we
> > should
> > basically have it working. Isn't that what you are about to do? If
> > so,
> > can you
> > tell me which points in my reply that you don't understand or fail
> > to
> > address?
>
> OK< if that is almost there then i will start from that. I had
> intended to start fresh.
>
> >
> > Or did I misunderstand?
>
> maybe slightly. :-) my point was that while the underlying operations
> are not the same between sftp and ftp, it would seem to me that the
> way that the fileinfo struct gets filled out should be the same so i
> should be able to use the ftp fileinfo fill out code as the place to
> start and then change it in the parts that gather the data since the
> sftp data gathering part will be different.
>
> but i dont think it matters ATM since i am going to work from that
> patch now.

It seems to me that this job should be done only in the state

"SSH_SFTP_QUOTE_STAT"

instead of being spread between SSH_SFTP_QUOTE_STAT and SSH_SCP_TRANS_INIT

or am i misunderstanding something about how the ssh state machine works?

tnx again!

johnu

> tnx!
>
> johnu
>
> > --
> >
> > / daniel.haxx.se
> > -------------------------------------------------------------------
> > List admin: http://cool.haxx.se/list/listinfo/curl-library
> > Etiquette: http://curl.haxx.se/mail/etiquette.html
> -------------------------------------------------------------------
> List admin: http://cool.haxx.se/list/listinfo/curl-library
> Etiquette: http://curl.haxx.se/mail/etiquette.html
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2011-01-29