hi Yang,

On Fri, Dec 17, 2010 at 5:32 PM, Yang Tse <yangsita_at_gmail.com> wrote:

> only modifying lib/Makefile.vc6 is not good enough
> for general use. If you wish to improve current VC6 Makefiles with
> this, please provide a separate patch for this feature.

Ah right, thanks, I only use libcurl, will update it accordingly.

>> @@ -402,7 +449,7 @@ RESOURCE = $(DIROBJ)\libcurl.res
>>  #######################
>>  # Usage
>>  #
>> -!IF "$(CFGSET)" == "FALSE" && "$(CFG)" != ""
>> +!IF ("$(CFGSET)" == "FALSE" && "$(CFG)" != "") || "$(CFG)"== ""
>>  !MESSAGE Usage: nmake /f makefile.vc6 CFG=<config> <target>
>>  !MESSAGE where <config> is one of:
>>  !MESSAGE   release                      - release static library
>
> This prevents usage of the 'clean' target. So some damage here, if applied.

OK.

> This usage, when WITH_DEVEL is defined, will only reflect a very
> specific layout of installed libraries.

The layout is not very specific, it is the contrary. It is rather
common. It reflects one to one what we have on unix for example. The
fact that many libraries do not provide an "install" procedure when
built from sources do not make the layout specific to one or another
library.

> I wonder if it is worth for
> general usage. In any case, I miss a default definition there for a
> LIBSSH2_PATH that would cover generic use, and easier modification for
> any given path.

I did not do it and did not plan to do it for the 1st phase. See my
comment below.

> First provide a separate patch that addresses definition and usage of
> LIBSSH2_PATH in both src/Makefile.vc6 and lib/Makefile.vc6, allowing
> both release and debug configurations of whatever other specific
> combination you support.

> Later on, when everything is working we could reconsider the WITH_DEVEL usage.

Not in my plan, from a time availability point of view. Having the
devel part done will spare me time at update time. As a side effect it
will also allow curl users to use pre-built dependencies from the ones
we use at php.net, a definitive big plus given the requests I get
lately. Once I'm done with that, I can take care of the LIBSSH2_PATH
addition (it is not available now anyway, no harm :).

Cheers,

-- 
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html