cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [Patch] Rewrite of security.c?

From: Julien Chaffraix <julien.chaffraix_at_gmail.com>
Date: Thu, 23 Sep 2010 09:53:55 -0700

> I did a casual read-through before I committed them all and pushed.

Thanks.

> Now, reading through them again I fell over what seems to be a mistake:
>
> commit fbb38de:
>
> http://github.com/bagder/curl/commit/fbb38de415b7bb7d743e53a7b4b887ffb12b3e5b
>
> That new memcpy() really can't be right, can it?

You are right, it should not have been touched. The new logic has
swapped buf and data so just revert all the changes to the method
(|data| should not be const...).

I will investigate why this was not detected by the existing test cases.

Julien
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2010-09-23