On Sat, 3 Jul 2010, Kamil Dudka wrote:

Updated patch kit attached. Explanations follow:

> Sorry for the mess. I think the proper solution would be to make sure the
> LD_PRELOAD solution is used only when the shared library is indeed there.
> I hope we can hook it somehow into the perl script.

I've not really solved this little piece of the puzzle yet, but I figure we
should use the $enable_shared variable within the configure script as a hint
if indeed shared building is enabled and only try LD_PRELOAD then. I think we
either make the perl scripts setenv-handling understand "LD_PRELOAD" and skip
it for non-shared, or we make a new "tag" (<preload> perhaps?) specificly for
LD_PRELOAD. I've not quite figured out the nicest way to get the
$enable_shared's contents to the perl script.

If you (as in anyone reading this) have any clever ideas, please bring them
on!

> Nope, the logic in sethostname.c looks fine. I've just badly broken the
> perl script. The 'tests/libtest/chkhostname' helper works fine to detect
> both of the overriden solutions. However the 'precheck' tag now always
> passes after my awkward chage of runtests.pl. I think I should not touch
> any perl code :-)

It was rather easy actually: the error code detected by 'precheck' was never
checked so even if the precheck failed properly the test case wasn't aborted
as it should. I fixed it and verified that it did indeed detect and abort on
failures. I modified the chkhostname.c check slightly to better output a
reason for its failure, as that is what gets seen by the user of runtests.pl.

>> Read 8 invalid bytes
>>
>> Conditional jump or move depends on uninitialised value(s)
>
> I see it more likely as problem of the dynamic linker. If something points
> to the newly added code, the backtrace would be quite helpful. I don't see
> them on my box.

I can still get these. As I'm on Debian unstable its not totally unthinkable
that I have a transient problem that might've been fixed already so I'll
just make sure I'm reasonably in synch and then I'll investigate these as
well.

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html