cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH v2] NTLM tests: boost coverage by forcing the hostname

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Fri, 2 Jul 2010 23:53:12 +0200 (CEST)

On Fri, 2 Jul 2010, Kamil Dudka wrote:

> Oops, and the code shift within runtests.pl also doesn't look perfect as it
> fails to skip some test-cases now. I'll probably need some help with the
> perl script...

I ran into another problem first, before I got a chance to check what you're
talking about up there!

I tend to build my dev version with configure --disable-shared, and when I do
that I get no libhostname.so for the LD_PRELOAD, I only get a libhostname.a
built which of course causes the preload to fail[*]. The nice part is of
course that your logic in sethostname.c is then perfectly getting the name
with the environment variable instead and the test can still work!

[*] = if I use valgrind when doing the LD_PRELOAD failure, it goes completely
bananas and shows me a long series of:

  Read 8 invalid bytes

  Conditional jump or move depends on uninitialised value(s)

... and I've had to ctrl-c break that output. So something is not quite right
there. Or here perhaps is a better term to use!

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2010-07-02