cURL / Mailing Lists / curl-library / Single Mail

curl-library

ftp wildcard related OOM handling

From: Yang Tse <yangsita_at_gmail.com>
Date: Wed, 9 Jun 2010 17:13:47 +0200

Hi Pavel,

The ftp wildcard matching code does some basic out of memory (OOM)
handling returning CURLE_OUT_OF_MEMORY when it detects that a memory
allocation has failed.

As a general rule, each function that fails with CURLE_OUT_OF_MEMORY
should also deallocate all memory it has requested before the function
returns with the CURLE_OUT_OF_MEMORY condition. Otherwise memory will
be leaked in 'low memory' conditions.

I was going to fix it myself but there are places where some code
reorganization might be necessary due to pointer aliases usage. So..

Could you spare some time to look into this wildcard related OOM
handling in ftplistparser.c and ftp.c?

Cheers,

-- 
-=[Yang]=-
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2010-06-09