curl-library
Re: [PATCH] Re: info about connection (ip/port)
Date: Fri, 28 May 2010 14:41:53 +0200
hi
here is a new patch. this time against git HEAD:
> A) 'struct sockaddr_storage' cannot be assumed to be around
> universally. You
> can however use 'struct Curl_sockaddr_storage' instead. You'll find
> that
> you need to adapt the code slightly to that.
>
> B) inet_ntop() cannot be assumed, use Curl_inet_ntop().
>
corrected
> C) conn->ip_addr_str already contains the remote IP address of the
> current
> connection you can copy it from there!
>
I knew there is the IP already written in there, since it is set on the
attempt of connecting.
I thought it is nice to have the connection info fields filled in in one
place the same way (getting infos from socket).
But if you think It's bad (performance/style) I just exclude this field
from being filled there.
> D) I'd like to see these new informational options to also get documented
> in the curl_easy_getinfo.3 man page so that people will be able to use
> them!
written the man entries for the new infos. I didn't know how to handle
the "(Added in ...)" part so I used "(Added in 7.xx.x)"
cheers, Frank
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
- text/plain attachment: curl-withipinfo.patch3