curl-library
Re: [PATCH] FTP WILDCARDMATCH option (only for now)
From: Pavel Raiskup <xraisk00_at_gmail.com>
Date: Fri, 14 May 2010 22:32:28 +0200
Date: Fri, 14 May 2010 22:32:28 +0200
>> Thank you. I've pushed the initial version now!
>
> ftplistparser.c, line 563:
> parser->state.UNIX.sub.group = PL_UNIX_SIZE_PRESPACE;
>
> Is that right? PL_UNIX_SIZE_PRESPACE isn't a part of the 'group' enum
> (it's part of the 'size' enum set).
>
> Line 627, same file: .size enum set to PL_UNIX_TIME_PREPART2 which is
> part of time, not size. There's a similar one another few lines down.
>
> (The above triggers warnings in builds, e.g.
> http://curl.haxx.se/auto/log.cgi?id=20100514085521-28048#prob5)
Thank you for revision!
I'm proposing patch with:
-- You mentioned errors
-- int32_t => unsinged int
-- one unreachable state removed
Pavel
Received on 2010-05-14