cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] librtmp support

From: Howard Chu <hyc_at_highlandsun.com>
Date: Wed, 12 May 2010 07:25:05 -0700

Daniel Stenberg wrote:
> On Wed, 12 May 2010, Howard Chu wrote:
>
>> OK. That one-line-per-ifdef style seems a bit excessive, but here you go.
>
> Right, if there's nothing that can separate them then there's no point in
> splitting them up. But further, perhaps we could just view them all as 'rtmp'
> to make things easier? The supported protocols are just info, they don't have
> to exactly list all the byte sequences that can start a URL that we support.
> Or should we have that? I can't but to help to think that the rtmp* list
> becomes a bit excessive...

Yeah. OK, I'm fine with that, as long as users don't whine and ask "how come
you don't support rtmpe?"

> It would also make sense to add librtmp/[version] to curl_version() like the
> other libs are. And if you don't have a way to (dynamically) extract librtmp's
> version, then I think you should really should consider adding one!

<librtmp/rtmp.h> defines RTMP_LIB_VERSION. Since we currently don't support
building as a shared library, I don't see any need (yet) for a runtime version
query. I'll add this to the patch...

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2010-05-12