cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: SMTP authentication: 2nd round !

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Mon, 19 Apr 2010 16:19:12 +0200 (CEST)

On Mon, 19 Apr 2010, Patrick Monnerat wrote:

> Sorry, I did not notice it since I use OpenSSL.
> This should be fixed now.

Nice, I get a warning however but I'll push a fix for this in a second.

Another little nit that sneaked into lib/smtp.c:

smtp.c:679: warning: statement with no effect

     /* Compute digest. */
-> strlen(conn->passwd);
     ctxt = Curl_HMAC_init(Curl_HMAC_MD5,
      (const unsigned char *) conn->passwd, strlen(conn->passwd));

The warning looks correct, but the line looks like just a leftover to remove?

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2010-04-19