cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: curl sftp shutdown error with MessageWay server

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Thu, 1 Apr 2010 20:19:14 +0200 (CEST)

On Thu, 1 Apr 2010, Matt Wixson wrote:

> curl-7.20.0: sendf.c, line 551
>
> #ifdef LIBSSH2CHANNEL_EAGAIN
> if 0
> /* OLD CODE retries on a 0 byte read (EOF) */
> if((nread == LIBSSH2CHANNEL_EAGAIN) || (nread == 0))
> #else
> /* NEW CODE only retries on EAGAIN */
> if((nread == LIBSSH2CHANNEL_EAGAIN))
> #endif
> /* EWOULDBLOCK */
> return -1;
> #endif

I can only say: well done Matt. A zero return code from that function really
should not be considered an error so I think that fix looks excellent. Thanks!

I'll commit this change to the main code in a little while.

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2010-04-01