tetetest tetetest wrote:
> Hello,
>
> Just a reminder in case the patch got lost among other messages.
>
> Or, if there are any errors or objectionable changes in the patch, can I
> have your
> feedback please?
>
> Attached it again, just for convenience.
>

- socklen_t
I still can not reproduce the issue you are having with socklen_t. I
have built with VS 2008 and it works fine. There must be a way to get
socklen_t on windows it is a system type. I guess this happens if an
application includes curl.h before windows.h? Can you provide a small
example program that shows this failure?

- CURL_PULL_SYS_TYPES_H 1

I guess this sort of goes with the socklen_t. If these are issues, I
think a new test file that shows the issue should be created and made
part of curl.

- remove curlbuild.h
Also, what is this for:
+# Remove include/curl/curlbuild.h file if exists.
+# Otherwise the build may be broken.
+execute_process(COMMAND "${CMAKE_COMMAND}" -E remove
+ ${CMAKE_SOURCE_DIR}/include/curl/curlbuild.h ERROR_QUIET)

I don't think you want to have that stuck in the cmake files forever..

- version of CMake required
Are you sure that 2.6.0 and 2.6.1 CMake will work? (did you test?)

-cmake_minimum_required(VERSION 2.6.2 FATAL_ERROR)
+cmake_minimum_required(VERSION 2.6 FATAL_ERROR)

-Bill

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2010-04-01