On Thu, Jan 21, 2010 at 3:47 AM, Daniel Stenberg <daniel_at_haxx.se> wrote:
> On Sun, 17 Jan 2010, Julien Chaffraix wrote:
>
>> with the upcoming 7.20.0 major release, I thought removing obsolete
>> entries in curl.h was a good idea. So here is a round at removing some old
>> defines in curl.h.
>
> Thanks.

You're welcome.

> Well. Yeah, I do like the idea, but I'm not so sure we should be doing it
> unless there's also a soname bump or something involved. As even though the
> obsolete entries have been obsoleted for a long while, I really don't like
> the idea of apps no longer compiling when we don't intend to break the API
> in any way. (And the times we've done that in the past, we've gotten some
> heat for it.)

Ok, I thought that a major release was sufficient for such an API
breakage. My bad, I should have asked prior to doing it (hopefully it
has unearthed some mismatches in the docs).

> So, I would rather instead play it more safe and make sure that the obsolete
> symbols are all within #ifndef CURL_NO_OLDIES sections so that apps that
> want to make sure they are not relying on old symbols can define
> CURL_NO_OLDIES.

I completely understand your point and the need to keep a stable
library (ABI- or API-wise).

> But of course I still want the documentation to be correct and refer to the
> current names (primarily at least).

Please find attached the watered down version of the patches. They
will not break the API and should fix the docs:

- 1: restore the right entries in symbol-in-versions
- 2: dropped
- 3: keep the libcurl-errors.3 changes
- 4: just add an entry for CURLE_FTP_PARTIAL_FILE in symbol-in-versions
- 5: mark CURLE_FTP_BAD_DOWNLOAD_RESUME as deprecated in
symbol-in-versions and update the documentation
- 6: already applied (see below)

> The "curl_passwd_callback" you remove in your 6- patch is a case of
> something that was removed already in our last soname bump so I'll apply
> that at once.

Thanks!

Regards,
Julien

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html