cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH v4] OpenSSL vs. NSS clash on PKG_CONFIG_LIBDIR

From: Kamil Dudka <kdudka_at_redhat.com>
Date: Wed, 13 Jan 2010 20:58:09 +0100

On Wednesday 13 of January 2010 20:47:26 Yang Tse wrote:
> -AC_DEFUN([CURL_EXPORT_PCDIR], [
> - if test -n "$1"; then
> +AC_DEFUN([CURL_EXPORT_PCDIR],
> + [if test -n "$1"; then
>
> Would prevent linefeed following opening backtick.

Wait, that's intentionally :-)

I just wanted the 'if' statement to really look as 'if' statement.

Do your really prefer this...

      SSL_LDFLAGS=`if test -n "$OPENSSL_PCDIR"; then
      PKG_CONFIG_LIBDIR="$OPENSSL_PCDIR"
      export PKG_CONFIG_LIBDIR
    fi
         $PKGCONFIG --libs-only-L openssl 2>/dev/null`

      SSL_CPPFLAGS=`if test -n "$OPENSSL_PCDIR"; then
      PKG_CONFIG_LIBDIR="$OPENSSL_PCDIR"
      export PKG_CONFIG_LIBDIR
    fi
         $PKGCONFIG --cflags-only-I openssl 2>/dev/null`

... over this?

      SSL_LDFLAGS=`
    if test -n "$OPENSSL_PCDIR"; then
      PKG_CONFIG_LIBDIR="$OPENSSL_PCDIR"
      export PKG_CONFIG_LIBDIR
    fi
         $PKGCONFIG --libs-only-L openssl 2>/dev/null`

      SSL_CPPFLAGS=`
    if test -n "$OPENSSL_PCDIR"; then
      PKG_CONFIG_LIBDIR="$OPENSSL_PCDIR"
      export PKG_CONFIG_LIBDIR
    fi
         $PKGCONFIG --cflags-only-I openssl 2>/dev/null`

> I think it is time to throw it at the daily builds

I forgot to tell I have already positive feedback from Dan for v3, so that
builders might be also happy...

Kamil
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2010-01-13