Hey guys,

let's go for the next iteration...

On Wed January 13 2010 04:04:05 Yang Tse wrote:
> Hmm, not sure if the above is clear enough. I mean something like ...
>
> if test -z "$MY_PKG_CONFIG_LIBDIR"; then
>
> SSL_LIBS=`${PKGCONFIG} --libs-only-l openssl 2>/dev/null`
>
> else
>
> SSL_LIBS=`PKG_CONFIG_LIBDIR=${MY_PKG_CONFIG_LIBDIR}; export
> PKG_CONFIG_LIBDIR; ${PKGCONFIG} --libs-only-l openssl 2>/dev/null`
>
> fi

Should be cleaner now.

> Relative to the next one, we are polluting current PKG_CONFIG_LIBDIR.
> Wasn't this the initial problem? Something similar to the up-above
> could be done when calling CURL_CHECK_PKGCONFIG, perhaps it could
> benefit from an additional parameter.
>
> + PKG_CONFIG_LIBDIR="$OPENSSL_PCDIR" CURL_CHECK_PKGCONFIG(openssl)
>

I've added an extra macro called CURL_EXPORT_PCDIR and modified
the CURL_CHECK_PKGCONFIG macro to take an optional argument.

On Wed January 13 2010 08:29:06 Daniel Stenberg wrote:
> Can I just ask that you also add a comment somewhere in there about the
> learned experience about PKG_CONFIG_LIBDIR's effect if empty vs
> non-existing so that we don't re-introduce this problem again in a couple
> of years when this thread gets forgotten!

Mentioned above the definition of CURL_EXPORT_PCDIR. Let me know if it is not
the best place for that comment.

Kamil

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html