cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] OpenSSL vs. NSS clash on PKG_CONFIG_LIBDIR

From: Yang Tse <yangsita_at_gmail.com>
Date: Tue, 12 Jan 2010 23:56:29 +0100

2010/1/12, Kamil Dudka wrote:

> I've hopefully resolved the configuration problem Dan Fandrich faced. It seems
> to be caused by the recent changes in OpenSSL checks, in particular by setting
> and then restoring the PKG_CONFIG_LIBDIR environment variables.
>
> The key problem is that pkg-config distinguishes among empty and unset. Thus
> only restoring the value was not sufficient. And having the variable empty
> instead of unset prevents pkg-config from finding nss properly.

> - export PKG_CONFIG_LIBDIR
> + if test -z "$PKG_CONFIG_LIBDIR"; then
> + unset PKG_CONFIG_LIBDIR
> + else
> + export PKG_CONFIG_LIBDIR
> + fi

Please. avoid using 'unset' it is not portable enough.

We are going great lengths in other parts of our shell code in
configure script macros to ensure that it works even on the most
unsupporting shells. This would be the first 'unset' in all of them.

-- 
-=[Yang]=-
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2010-01-12