On Thu, 7 Jan 2010, Claes Jakobsson wrote:

>> Additionally, tests/data/Makefile.am is missing references to test1109
>> test1110 test1111.
>
> Hm.. that I did not know =(, they ran when I did a make test. I'll fix that.

Right, 'make test' runs all locally found test cases while Makefile.am makes
sure that they are included in tarballs. I do this mistake all the time... :-/

Maybe we should consider adding some kind of system that shows something
informative if a test that is run is not included in the Makefile.am. There's
a special check right now that will show this:

$ cd tests/data && make filecheck

> but other than that, was my first integrating someones patch ok?

It looked fine to me!

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html