cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] FTP PRET support for drftpd servers

From: Ingmar Runge <ingmar_at_irsoft.de>
Date: Fri, 1 Jan 2010 12:48:58 +0100

So, I copied the test files to tests/data and ran ./runtests.pl 1107.
This is what happens:

********* System characteristics ********
* curl 7.20.0-CVS (x86_64-unknown-linux-gnu)
* libcurl/7.20.0-CVS OpenSSL/0.9.8l zlib/1.2.3 libidn/1.15
* Features: IDN IPv6 Largefile NTLM SSL libz
* System: Linux 2.6.31-gentoo-r6 #2 SMP Sat Dec 5 16:09:26 CET 2009
x86_64 Intel(R) Core(TM) i7 CPU 920 @ 2.67GHz GenuineIntel GNU/Linux
* Server SSL: OFF libcurl SSL: ON
* debug build: OFF track memory: OFF
* valgrind: OFF HTTP IPv6 ON
* FTP IPv6 ON Libtool lib: OFF
* SSL library: OpenSSL
* Ports:
* HTTP/8990 FTP/8992 FTP2/8995
* TFTP/8997 HTTP-IPv6/8994 FTP-IPv6/8996
* SSH/8999 SOCKS/9000 POP3/9001 IMAP/9002 SMTP/9003
*****************************************
]est 1107...[FTP RETR PASV with PRET

 data FAILED:
--- log/check-expected 2010-01-01 12:44:35.000000000 +0100
+++ log/check-generated 2010-01-01 12:44:35.000000000 +0100
@@ -1,6 +0,0 @@
-data
- to
- see
-that FTP
-works
- so does it?

 - abort tests
TESTDONE: 0 tests out of 1 reported OK: 0%

The strange thing is that log/stderr1107 says:

  : is unknown --ftp-pret
  curl: try 'curl --help' or 'curl --manual' for more information

which is REALLY strange because:

  x_at_y ~/curl/tests $ curl --help | grep pret
  x_at_y ~/curl/tests $ ../src/curl --help | grep pret
      --ftp-pret Send PRET before PASV (for drftpd) (F)
  x_at_y ~/curl/tests $ grep curl runtests.pl
  my $CURL="../src/curl"; # what curl executable to run on the tests
  my $VCURL=$CURL; # what curl binary to use to verify the servers with
  my $DBGCURL=$CURL; #"../src/.libs/curl"; # alternative for debugging

So it looks like it's running the wrong binary? Am I missing something here?

Thanks!
~Ingmar

On Mon, Dec 28, 2009 at 17:01, Daniel Stenberg <daniel_at_haxx.se> wrote:
> On Mon, 28 Dec 2009, Ingmar Runge wrote:
>
> I didn't test or apply any code yet but here are two suggested test cases
> for this feature, trying PRET both with and without server support! They may
> thus need some adjustments to work perfectly.
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2010-01-01