cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: v2 of patch to fix busy-waiting during Windows async name lookup

From: Constantine Sapuntzakis <csapuntz_at_gmail.com>
Date: Sun, 6 Sep 2009 15:55:59 -0700

Attached is a patch that addresses the issues below.

On Sun, Sep 6, 2009 at 10:59 AM, Daniel Stenberg <daniel_at_haxx.se> wrote:

> I think a CURLMOPT_NODUMMY option is pointless.
>
> * More warnings about select() in the documentation
>>
>
> I don't like them.
>
> * modified examples to handle maxfd==-1 on Windows
>>
>
> I don't like that either.
>

> So IMO: we either make the examples work portably and remove the comments,
> or we leave the comment in there and don't half-adress the issue.
>

Reverted the examples

> And a minor nit: we don't use // comments in curl code.
>

Done

-Costa

Received on 2009-09-07