curl-library
RE: OS400 ftp server related problem
From: Daniel Stenberg <daniel_at_haxx.se>
Date: Tue, 18 Aug 2009 18:15:46 +0200 (CEST)
Date: Tue, 18 Aug 2009 18:15:46 +0200 (CEST)
On Mon, 17 Aug 2009, Patrick Monnerat wrote:
> The patch latches the OS name in a new ftp_conn structure field (server_os),
> in case someone needs it elsewhere in the code.
>
> Daniel, I'm waiting your approval before commit.
I only spotted one nit: it calls malloc() and assumes it'll always work so it
will quickly fail a "torture test".
Also, it would be neat if you could write up a test case that verifies this
functionality to prevent us from accidentally breaking it later on...
-- / daniel.haxx.seReceived on 2009-08-18