cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] transfer.c fixes for CURL_DO_LINEEND_CONV and non-ASCII platform HTTP requests

From: David McCreedy <mccreedytpf_at_gmail.com>
Date: Tue, 5 May 2009 09:19:00 -0600

On Tue, May 5, 2009 at 6:53 AM, Yang Tse <yangsita_at_gmail.com> wrote:

> Hi David,
>
> With the "transfer.c fixes for CURL_DO_LINEEND_CONV and non-ASCII
> platform HTTP requests" patch already committed in CVS, test case #128
> fails on cygwin.
>
> On cygwin CURL_DO_LINEEND_CONV is defined and CURL_DOES_CONVERSIONS is
> undefined.
>
> The quick hack patch attached here makes it work again on cygwin, but
> I'm not sure if it the best fix.
>
> Could you verify which would be the proper fix?
>
> --
> -=[Yang]=-
>

The 2nd part of the patch (moving the !sending_http_headers check so it's
only done on the #else) causes test 553 to fail on TPF.

With only the 1st part of the patch in place does cygwin work without the
2nd part of the patch?
I've tested that (making the !sending_http_headers check apply to both the
#if and #else) and it works on TPF.
Perhaps that's an option.

Unfortunately I don't have a cygwin setup to test with.

Thanks,

-David
Received on 2009-05-05