cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: sukender: curl/tests/libtest CMakeLists.txt,NONE,1.1

From: Piotr Dobrogost <pd_at_opensource.dobrogost.pl>
Date: Fri, 10 Apr 2009 22:48:03 +0200

Sukender

In the root CMakeLists.txt there is this code

IF(WIN32)
  SET(CURL_LDAP_HYBRID OFF)
  OPTION(CURL_LDAP_WIN "Use W$ LDAP implementation" ON)
  MARK_AS_ADVANCED(CURL_LDAP_WIN)
ELSE()
  OPTION(CURL_LDAP_HYBRID "W$ LDAP with non-W$ compiler" OFF)
  MARK_AS_ADVANCED(CURL_LDAP_HYBRID)
  SET(CURL_LDAP_WIN OFF)
ENDIF()

I think that for consistency that should be rather

IF(WIN32)
  OPTION(CURL_LDAP_WIN "Use W$ LDAP implementation" ON)
  MARK_AS_ADVANCED(CURL_LDAP_WIN)
  SET(CURL_LDAP_HYBRID OFF)
ELSE()
  OPTION(CURL_LDAP_HYBRID "W$ LDAP with non-W$ compiler" OFF)
  MARK_AS_ADVANCED(CURL_LDAP_HYBRID)
  SET(CURL_LDAP_WIN OFF)
ENDIF()

Sorry for this nitpicking but that's my way of thinking. I'm trying to
point out everything that seems to be not right no matter how important
it is. :)

-- 
Piotr Dobrogost
*** curlpp.org - c++ wrapper for libcurl ***
Received on 2009-04-10