cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: sukender: curl/include/curl curl.h,1.380,1.381

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Thu, 9 Apr 2009 08:17:26 +0200 (CEST)

On Thu, 9 Apr 2009, Yang Tse wrote:

> Could this
> http://cool.haxx.se/cvs.cgi/curl/include/curl/curl.h.diff?r1=1.380&r2=1.381
> change be rolled back now that I've made test #558 and #559 being also
> skipped when testing a Win32 libcurl DLL?

It should be reverted. It is substandard.

We ONLY add dependencies on custom variables if they are properly prefixed and
this USES_DIRECT_CURL_UTILITIES one isn't.

Not to mention that there's no comment or other explanation for the define
which should be a requirement as well.

-- 
  / daniel.haxx.se
Received on 2009-04-09