cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: CURLOPT_LOCALPORT option broken ?!

From: Senthil Raja Velu <Senthil.Raja_at_ss8.com>
Date: Wed, 25 Feb 2009 11:08:18 -0800

Dan, Markus,
OK, I will wait for the final updated patch.

Thanks,
Senthil.

-----Original Message-----
From: curl-library-bounces_at_cool.haxx.se
[mailto:curl-library-bounces_at_cool.haxx.se] On Behalf Of
koettermarkus_at_gmx.de
Sent: Wednesday, February 25, 2009 2:49 AM
To: libcurl development
Subject: Re: CURLOPT_LOCALPORT option broken ?!

Daniel Stenberg wrote:
> On Tue, 24 Feb 2009, koettermarkus_at_gmx.de wrote:
>
>> Hopefully the last version of the patch is attached.
>
> Thanks!
>
> Here's my take at re-arranging it. I removed all gotos and a
superfluous
> strncpy() call and I made all lines shorter than 80 columns and the
code
> now uses standard curl indentation.
>
> Does this still work fine for you guys?
>

No, you broke the logic, the Curl_sockaddr_storage is not written.

change line 360 to match:

360 if(done) {
361 #ifdef ENABLE_IPV6
362 /* ipv6 address */

instead of
360 if(!done) {

MfG
Markus
Received on 2009-02-25