"Daniel Stenberg" <daniel_at_haxx.se> wrote in message
news:alpine.LRH.2.00.0901121952120.2812_at_yvahk3.pbagnpgbe.fr...
> On Sun, 11 Jan 2009, Markus Moeller wrote:
>
>> Please find attached a patch to curl 7.19.2 which adds Socks5 GSSAPI
>> authentication. It works on Unix and Windows.
>
> Thanks a lot! Here follows my comments on it:
>
> - FYI: it won't be included in 7.19.3 since we're in a feature freeze
> right
> now

Ok I did just make an assumption.

>
> - don't you think the two options CURLOPT_SOCKS5_GSSAPI_SERVICE and
> CURLOPT_SOCKS5_GSSAPI_NEC are better added as a 'proxytype' ? You can't
> combine them with the other socks variations anyway, can you? And that's
> how
> we currently select between SOCKS 4, 5, 4A and 5-hostname... Or will
> socks5
> and socks5-hostname both still work with these?
>

These are additional options for socks5.

> - it uses #if [define] and #elif [define] on several places where it
> should do #ifdef [define] and #elif defined([define]) to be clean
>

Will fix that.

> - it uses code wider than 80 columns at a few places
>

Ok I thought I checked.and will fix.

> - library-internal globals should be prefixed Curl_, like blockread_all
> when
> converted from being a static should probably be renamed to
> Curl_blockread_all() or similar.
>

I wasn't aware of that convention and will fix.

> - there's no docs added for the new options, in neither libcurl nor curl
>

I will add.

> --
>
> / daniel.haxx.se
>

Thank you
Markus
Received on 2009-01-12