> > If the handle is head, it is removed from pipelines without any fix
at all
> > (from within singlesocket()). Therefore in this case there is no
need to
> > call Curl_getoff_all_pipelines() at all.
>
> Well it is also called from Curl_done() and afaicr it might be head
when
> called from there.

We can leave the original Curl_done, I mean - without
Curl_getoff_all_pipelines.
And, obviously, to add the "Curl_getoff_all_pipelines"-style code
directly into curl_multi_remove_handle().

> > Despite that I would insert the latest (fixed) version of
> > Curl_getoff_all_pipelines, Since it makes the code more readable.
>
> But with the head-check it is slightly more code being excuted so I
rather
> only have it this way if actually used...

It's you decision :)
I will be happy with both fixes, with or without the
Curl_getoff_all_pipelines.

Respectfully yours,
Igor
Received on 2008-12-09