cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: [PATCH] Colon in username

From: Igor Novoseltsev <IgorN_at_radvision.com>
Date: Sun, 28 Sep 2008 07:57:39 +0300

OK,
Get me in details of your idea.

1. What is the set of arguments needed in order to set byte array?
   I thought the null-terminated string of percent encoding chars is
enough.

2. I need the username to appear as a parameter of the Authorization
header.
   It should be taken as is while calculating digest response parameter.
   Therefore the libcurl should use URL decoded form of the stored
USERNAME string
   while performing the authentication (calculating hash and inserting
the username into header).
   Such change looks to me as overhead for feature that was not
requested yet. What do you think?

Thanks,
Igor

-----Original Message-----
From: curl-library-bounces_at_cool.haxx.se
[mailto:curl-library-bounces_at_cool.haxx.se] On Behalf Of Daniel Stenberg
Sent: Thursday, September 25, 2008 5:17 PM
To: libcurl development
Subject: RE: [PATCH] Colon in username

On Thu, 25 Sep 2008, Igor Novoseltsev wrote:

> The "really wild" API forces an application to perform URL encoding.
For
> now, my application is simply enough to not bother with encoding at
all. May
> be there are other applications that don't deal with encoding.

Well, libcurl provides a function to do the URL encoding so it would not

exactly be hard for an app to encode whatever name it wants.

> While taking in account that the patched code can be easily extended
in
> future to work with byte array, I would prefer not to work on this
now, when
> no specific requirement arose.

But introducing encoded names in the future will then require another
set of
arguments or break the ABI and that would be an excessive amount of
options
for the same things. Of course nobody ever asked for being able to
include
zeroes in these fields so it's not really a big deal.

-- 
  / daniel.haxx.se
Received on 2008-09-28