On Fri, Sep 12, 2008 at 2:22 PM, Yang Tse <yangsita_at_gmail.com> wrote:
> 2008/9/12, E L <crc1021_at_gmail.com> wrote:If the connection
>> gets reset, the call to send() or recv() will fail, but there is a
>> good chance errno will still be set to EAGAIN, so the code will keep
>> trying indefinititely.
>
> Yes the real problem is that errno is not being cleared for WIN32 if
> the call to recv() or send() succeeds!
>
>> patch is included below to set errno for all send() and recv()
>
> Your patch was real close, but it doesn't address the above statement.
>
> Could you verify if the attached patch works fine for you, and report
> back to the list, so that someone might commit it to CVS ?

Right now, the code works because errno is only checked if the result
of the socket call fail, so clearing it before the call is not needed.
 The bigger issue is that on Windows, send() and recv() do not set
errno at all.
http://msdn.microsoft.com/en-us/library/ms737828(VS.85).aspx

I'm running the patched version right now and it is working.
Received on 2008-09-12