cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: left before release

From: Dan Fandrich <dan_at_coneharvesters.com>
Date: Wed, 27 Aug 2008 19:02:08 -0700

On Fri, Aug 22, 2008 at 10:30:45AM -0700, I wrote:
> There's also the test case 1065 failure (HTTP PUT with one file but two URLs).
> Not a critical bug, but there nonetheless. I'm not sure that reverting
> to a GET after the PUT is the right solution--I can't think of another type
> of transaction where curl treats different URLs on the command line
> differently. The analagous POST case posts the same data to all URLs, for
> example.

I figured out the root of the problem: the second URL acts as though it wants
to do a GET but it actually sends a PUT request. The solution is to fix
the CURLOPT_UPLOAD handling so that when given a 0 value it sets the
HTTP request back to GET (or HEAD). A very similar fix went in four years
ago to do the same thing with the CURLOPT_POST option.

It does mean that the curl command-line will do both a PUT and a GET from
the command line if only one -T option is given and several URLs. The
change shouldn't affect any correct clients--only those who set CURLOPT_UPLOAD
to 0 and then expect to do an upload anyway.

>>> Dan

-- 
http://www.MoveAnnouncer.com              The web change of address service
          Let webmasters know that your web site has moved
Received on 2008-08-28