cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Modification of curl_multi_fdset()

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Mon, 9 Jun 2008 17:19:56 +0200 (CEST)

On Mon, 9 Jun 2008, Alexey Simak wrote:

>> No you can't. The code in the patch you submitted still uses the socket
>> from
>
> Hm, cannot agree with you. read_fd_set is NULL here, so nothing is added to
> read_fd_set, variable "added" becomes "1" only if something is added to
> write_fd_set. So this_max_fd is changed only if write_fd_set is not empty.

Ah right, you're right. I got confused by the use the socket in the read case:

          s = sockbunch[i];

When in fact the variable isn't used for anything but to possibly abort the
loop. Sorry for not reading the code correctly.

BTW, will you update the patch and provide a docs update with it?

-- 
  / daniel.haxx.se
Received on 2008-06-09