Dan Fandrich wrote:
> On Wed, May 21, 2008 at 04:34:56PM -0400, David Rosenstrauch wrote:
>> As promised, here's my patch of tweaks required for building libcurl with
>> SPNEGO support on Windows Visual C++.

>> Any questions/issues, please let me know.
>
>> +++ curl-7.18.2-CVS-work/lib/config-win32.h 2008-05-20 12:09:37.258864400 -0400
> [...]
>> /* Define if you have the <stdlib.h> header file. */
>> +#ifndef HAVE_GSSMIT
>> #define HAVE_STDLIB_H 1
>> +#endif

> It seems to me these changes would affect all of libcurl; why exactly is
> this needed only with the HAVE_GSSMIT case?

All of the changes I made are to fix various compilation and linkage
errors that occur with the pristine source code.

For the specific changes you cited above, MIT KFW also defines these
preprocessor definitions (in the win-mac.h file), which results in
duplicate definition errors. So the ifndef's are required to get the
code to compile.

But I can't speak to whether or not it makes sense to remove those
defines for all of libcurl. Perhaps others with better knowledge of the
code can comment.

>> +++ curl-7.18.2-CVS-work/lib/file.c 2008-05-20 12:05:38.106555600 -0400
>> @@ -90,7 +90,7 @@
>> /* The last #include file should be: */
>> #include "memdebug.h"
>>
>> -#if defined(WIN32) || defined(MSDOS) || defined(__EMX__) || defined(__SYMBIAN32__)
>> +#if (defined(WIN32) || defined(MSDOS) || defined(__EMX__) || defined(__SYMBIAN32__)) && !defined(HAVE_GSSMIT)
>> #define MSDOS_FILESYSTEM 1
>> #endif
>
> This definitely looks fishy. Why would enabling GSSMIT cause the filesystem
> conventions to change for file: URLs?

Again, this is to work around a duplicate definition error in win-mac.h.

DR
Received on 2008-05-21