cURL / Mailing Lists / curl-library / Single Mail


Re: [PATCH] Missing malloc() return-value check in lib/http_negotiate.c

From: Daniel Stenberg <>
Date: Sat, 12 Apr 2008 13:52:31 +0200 (CEST)

On Fri, 11 Apr 2008, Andre Guibert de Bruet wrote:

> I have attached a patch which adds a missing NULL check in http_negotiate.c
> in the HAVE_SPNEGO case. It also changes the return value of
> Curl_input_negotiate() to CURLE_OUT_OF_MEMORY instead of ENOMEM.

Thanks! I committed it with some minor edits and an added comment.

The function just returns 0 for sucess or non-zero for failure so using CURLE*
codes don't make any difference. The function is in fact riddled with return
codes that aren't CURLcode at all... Certainly rooom for improvement there!

  Commercial curl and libcurl Technical Support:
Received on 2008-04-12