cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Negotiate: crash

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Thu, 21 Feb 2008 09:06:04 +0100 (CET)

On Wed, 20 Feb 2008, Anatoli Tubman wrote:

> (1) The same connection is reused to fetch two URLs *and*
> (2) WWW-Authenticate: Negotiate is used for both URLs
>
> To reproduce, simply fetch the same URL twice from the command tool
> while using Negotiate:
>
> curl http://example.com/ http://example.com/ --negotiate -u :

Unfortunately I don't think any of the main developers have any means of
testing Negotiate. I know I can't at least.

> The reason is probably the negotiate context not being cleaned up properly
> in the end of the first fetch. I was able to fix the problem by calling the
> cleanup routine in the end of Curl_output_negotiate() (instead of just
> freeing the token) but I'm not sure whether this is the right thing to do.

_instead_ of freeing? Won't you then get a memory leak?

Can you show us what you did as a patch?

-- 
  Commercial curl and libcurl Technical Support: http://haxx.se/curl.html
Received on 2008-02-21