curl-library
Re: [PATCH] Better pipelining, round two
Date: Tue, 15 Jan 2008 13:49:06 +0100 (CET)
On Mon, 14 Jan 2008, Dmitry Kurochkin wrote:
> Here is second version of the patch. I think it fixes all mentioned issues 
> with previous version. Changes:
I'm fine with these changes. One thing that struck me, that I wanted to try 
on you is this:
Shouldn't we better move most (if not all) those pipelining functions from 
lib/url.c to lib/multi.c instead since they're all basically just used from 
there? Then we can make them static and we'll make url.c slightly smaller...
Possibly we could even make a new source file for just the pipelining magic, 
but I'm not sure that'll give us many benefits right now.
Your thoughts on this?
> ./runtests.pl -t 530 still fails for me. But:
I fails for me too, and it says it fails on 1054 but when I re-run with -t1054 
it runs fine, although I can make it fail repeatedly with -t1053...!
But I'm now quite sure this isn't related to your patch at all, since I get 
this problem (at the exact same spot) even without your patch applied! :-/
("LIMIT multi.c:1418 malloc reached memlimit" with the current CVS code...)
I'll see if I can sort it out...
-- Commercial curl and libcurl Technical Support: http://haxx.se/curl.htmlReceived on 2008-01-15