cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: curl_easy_escape() and curl_easy_unescape() length arguments data types

From: Dan Fandrich <dan_at_coneharvesters.com>
Date: Mon, 14 Jan 2008 14:19:33 -0800

On Mon, Jan 14, 2008 at 09:29:47PM +0100, Yang Tse wrote:
> Right now we have int as the data type for the length arguments as:
>
> char *curl_easy_escape(CURL *handle, const char *string, int inlength);
> char *curl_easy_unescape(CURL *handle, const char *string, int length,
> int *olen);
>
> Right now both functions will misbehave on OSs where sizeof(int) !=
> sizeof(ssize_t) when trying to handle an input string with a length
> that does not fit in an 'int' even when the length argument is not
> specified.
>
> Probably all three lengths should be changed to 'size_t'.
>
> Before release, after release, or forget about it ;-) ?

That means a binary compatibility break, so it should probably be added
to the appropriate section of the TODO file. But it sounds like something
that should be done.

>>> Dan

-- 
http://www.MoveAnnouncer.com              The web change of address service
          Let webmasters know that your web site has moved
Received on 2008-01-14