Re: [PATCH] socklen_t fix attempt
Date: Sat, 22 Dec 2007 23:45:43 +0100 (CET)
On Fri, 21 Dec 2007, Yang Tse wrote:
> Even further, I think that there would be no need to delete anything from
> include/curl/ on make clean. All three, types.h.in types.h.dist and types.h
> should be kept around. So the question here is. Is it better an empty
> CLEANFILES or just remove the line.
It should probably just get removed.
> Probably curl/include/README would also need some editing.
Indeed, and buildconf.bat need to make the types.h.dist get copied to types.h.
> So I guess, that in the long run, it is better if we finally do this instead
> of just changing socklen_t over to for example 'unsigned int' in the public
I've been bouncing this around in my head for a while now and I think I'd
rather go "unsigned int" (in the public header) for now, rather than to
introduce the new types.h thing.
My reasoning for this is that the types.h approach is a lot more complicated
so as long as we don't really need it I think we gain (or rather keep)
simplicitly and readability by not doing it that way. We've felt the area now
so I think we have a better idea about this for the future if we run into
another issue that we simply cannot duck for in this (perhaps not so elegant
but at least mostly working) way.
-- Commercial curl and libcurl Technical Support: http://haxx.se/curl.htmlReceived on 2007-12-22